Use RenderStartup for all basic cases in bevy_core_pipeline.
#20002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriyDev
added
A-Rendering
IceSentry
approved these changes
Jul 7, 2025
atlv24
approved these changes
Jul 9, 2025
| render_app | ||
| .init_resource::<BlitPipeline>() | ||
| .init_resource::<SpecializedRenderPipelines<BlitPipeline>>(); | ||
| .allow_ambiguous_resource::<SpecializedRenderPipelines<BlitPipeline>>() |
There was a problem hiding this comment.
i feel like a lot of "just data" resources like this and configs etc should be allow_ambiguous_resource. Immutable resources pleaaaaaasseeeeeeeeeeeeee @alice-i-cecile
andriyDev
added
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@alice-i-cecile I have discovered that the culprit is So I think we can move forward merging this PR. |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
FromWorldimpls into systems.RenderStartup.Testing
bloom_3d,auto_exposure,depth_of_field,motion_blur,skybox,post_processing, andtonemappingexamples and they all work :)